Re: Drop support for libreadline
| From: | Christoph M. Becker | Date: | Wed, 13 Feb 2019 11:51:01 +0000 |
| Subject: | Re: Drop support for libreadline | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-104385@lists.php.net to get a copy of this message | ||
On 13.02.2019 at 11:56, Remi Collet wrote:
> Terribly old and known issue.
>
> libreadline license (GPL) is incompatible with PHP
>
> We support build with libedit (BSD) for years
>
> Most Linux distribution use libedit
> Windows also use libedit
>
>
> So, this PR is mostly a cleanup of what should have been removed for years.
>
>
> Feedback before merge ?
I'm fine with dropping libreadline support, but it should be pointed out
that readline_list_history() doesn't work with libedit, and would be
completely removed.
--
Christoph M. Becker