Re: Drop support for libreadline
| From: | Johannes Schlüter | Date: | Wed, 13 Feb 2019 14:51:33 +0000 |
| Subject: | Re: Drop support for libreadline | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-104388@lists.php.net to get a copy of this message | ||
Hi,
On Mi, 2019-02-13 at 11:56 +0100, Remi Collet wrote:
> Hi,
>
>
> Terribly old and known issue.
>
> libreadline license (GPL) is incompatible with PHP
>
> We support build with libedit (BSD) for years
>
> Most Linux distribution use libedit
> Windows also use libedit
>
>
> So, this PR is mostly a cleanup of what should have been removed for
> years.
>
I don't know the size of the patch for this, but as long as we are not
using readline-specific APIs isn't it the user's choice/responsibility
if they happen to link to readline? - As long as that isn't
distributed, but only for their own use it's fine. GPL limits
"redistribution" not "usage"
It is a while since I used libedit last, but in behavior it had notable
differences.
johannes