Re: browscap.ini module error + fix

Before committing this, could you look at the browscap.c version in HEAD? I made similar changes a month or so ago but I didn't MFH because it affected BC a bit. The fix was for a segfault, but I added the '^' thing, too. See browscap.c version 1.69 for the change (1.70 just has the superglobal JIT thing.) I can MFH the changes to 4.3 if there's no objections. I just left it in HEAD because of the minor BC divergance. (Very minor -- I ran a stock 4.3 and a modified browscap.c against 200 MB worth of Apache logs and the difference in reported browsers was negligible.) J Uwe Schindler wrote: > Was only to look through the code. But the patch is here (PHP4.3 version). > > Uwe > > At 12:12 27.04.2003 +0100, Wez Furlong wrote: > > >>On Sun, 27 Apr 2003, Uwe Schindler wrote: >> >> > So I modified the browscap.c file that it adds a ^ at the beginning of >> > regex and a $ at the end of regex. After that all browsers are detected >> > exactly like in ASP. Browsers with errors are: IE, Konqueror, some >> spiders... >> > >> > The modification looks like that: >> > >/* {{{ convert_browscap_pattern >> > > */ >>[snip] >> >> > If you also think thats right can you give my thetaphi@php.net CVS >> > account write access to ext/standard, i will then submit the >> > modifications? >> >>Lets have a unified diff first? (see README.SUBMITTING_PATCH). >> >>--Wez.