Re: browscap.ini module error + fix

OK. I think we should apply your patch to 4.3, too. At 12:12 28.04.2003 -0400, Jay Smith wrote:

Before committing this, could you look at the browscap.c version in HEAD? I made similar changes a month or so ago but I didn't MFH because it affected BC a bit. The fix was for a segfault, but I added the '^' thing, too. See browscap.c version 1.69 for the change (1.70 just has the superglobal JIT thing.) I can MFH the changes to 4.3 if there's no objections. I just left it in HEAD because of the minor BC divergance. (Very minor -- I ran a stock 4.3 and a modified browscap.c against 200 MB worth of Apache logs and the difference in reported browsers was negligible.) J

The reported browsers are correct, but not complete reported. For example Internet Explorer (as I told in my post) is correctly detected (because of the [IE x.x] which is in the user agent), but the exact version and platform not. And because of this a lot of scripts fail because get_browser()->platform is for example undefined. And IE is one of the most used browsers... ----- Uwe Schindler Addr 1: Bamberger Str. 24a, D-96049 Bamberg Addr 2: Drausnickstr. 153, D-91052 Erlangen http://www.thetaphi.de - http:///www.schindlers-software.de eMails: uwe@thetaphi.de (private); info@schindlers-software.de (company) Tel./Fax: +49 700 PCLATEIN (+49 700 72528346) Schindlers Software - Home of Schindlers PC-LATEIN 3.10 DIE Software zum Lateinlernen!