Re: Should changes to EXTENSIONS be with a direct master commit?
| From: | Nikita Popov | Date: | Fri, 20 Sep 2019 07:52:15 +0000 |
| Subject: | Re: Should changes to EXTENSIONS be with a direct master commit? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107254@lists.php.net to get a copy of this message | ||
On Fri, Sep 20, 2019 at 6:48 AM Bishop Bettini <bishop.bettini@gmail.com>
wrote:
> I've got the change below staged locally, but as you can see it's direct to
> master. Since that's an atypical workflow, and a first time for me, I
> wanted to check before I push.
>
> --- BEGIN git log ---
> commit f94d9dcc102ea5515974b3a721286a6b49840860 (HEAD -> master)
> Author: Bishop Bettini <bishop@php.net>
> Date: Fri Sep 20 00:31:59 2019 -0400
>
> [ci skip] Add phar + imap maintainer email
>
> Looks like commit c09b13cb (Add Bishop Bettini as maintainer for
> phar & imap, 2019-03-16) missed adding my email address.
>
> --- END git log ---
>
> Is this an appropriate case for a direct master commit?
>
Yes, this is fine. php-src has no strict review policy, use your own
judgement :) You'll likely want to get larger extension changes reviewed,
but especially if it's just about documentation changes, going through a PR
is not necessary.
Nikita