Re: function registration patch

If the memory manager is usable at this point (I think it is) then you should use do_alloca() and free_alloca() instead of malloc()/free(). Andi At 04:54 PM 3/18/2003 -0500, Andrei Zmievski wrote:

Currently when registering functions, the unmodified function name is used as the key for the function table. This leads to problems when an extension class has a constructor that is not all lowercased. For example: function_entry php_gtk_button_functions[] = { PHP_FE("GtkButton", NULL), ... }; Then when using something like: ... parent::GtkButton(); ... It fails because it uses 'gtkbutton' as the key to search the function table. The attached patch fixes that by lowercasing the key (function name) when registering functions. I know that some may say, "just use lowercase class name for the constructor in the function entry list", but that messes with nice class/function names again.

-Andrei                                       http://www.gravitonic.com/

* It said 'Winmodem' on the box, but I still feel like I lost. * -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php