Re: [RFC] Amendments to Attributes
| From: | Nikita Popov | Date: | Fri, 22 May 2020 15:28:13 +0000 |
| Subject: | Re: [RFC] Amendments to Attributes | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-110247@lists.php.net to get a copy of this message | ||
On Fri, May 22, 2020 at 2:19 PM Benas IML <benas.molis.iml@gmail.com> wrote:
> Agreed.
>
> I don't think we should pollute any other than the
PHP\
> namespace. If
> that RFC doesn't pass though, we should keep the Attribute
> class in the
> global namespace.
>
> Global namespace is already reserved for PHP and so, BC breaks aren't that
> severe whereas Attributes\ namespace isn't reserved
> therefore BC breaks
> would be "unexpected".
>
> Best regards,
> Benas Seliuginas
>
I mean, realistically speaking, BC breaks with Attributes\Attribute are a
lot less likely than with just Attribute, regardless of what we reserve or
don't. Some pragmatism, please.
I don't particularly care what namespace the attribute classes are under,
just that they should have a common namespace, because there's going to be
many of them, presumably. If it was just a matter of the Attribute class,
I'd definitely say this belongs in the global namespace, but that's not
what we're dealing with at this point.
Nikita