Re: [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods
| From: | Pedro Magalhães | Date: | Wed, 27 May 2020 08:40:02 +0000 |
| Subject: | Re: [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-110285@lists.php.net to get a copy of this message | ||
On Wed, May 27, 2020 at 8:23 AM Alexandru Pătrănescu <drealecs@gmail.com>
wrote:
> In terms of what final does to a private method, as I understand, it will
> just be ignored everywhere? (except for constructor)
> I mean, final deny overriding but private methods cannot be overridden by
> design. We should have that in the documentation as well, I guess.
>
Hi Alex.
Indeed, it would just be ignored. Optionally, as the other open issue of
the RFC currently proposes, we would throw a warning on those cases
precisely to warn the user that it is meaningless.
And yes, I agree that the docs should be updated to explain that explicitly..
Regards,
Pedro