Re: [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods

From:	Pedro Magalhães	Date:	Mon, 08 Jun 2020 15:58:46 +0000
Subject:	Re: [RFC] [Discussion] Remove inappropriate inheritance signature checks on private methods
References:	1 2 3 4 5	Groups:	php.internals
Request:	Send a blank email to internals+get-110427@lists.php.net to get a copy of this message

On Wed, May 27, 2020 at 12:07 AM Pedro Magalhães <mail@pmmaga.net> wrote:

> On Tue, May 26, 2020 at 3:46 PM Marco Pivetta <ocramius@gmail.com> wrote:
>
>> Considering that, as far as I know, only the constructor remains
>> "special".
>>
>
> Leaving the special case only for constructors instead of all magic
> methods sounds better to me. Right now, that sounds like a winning
> compromise for the RFC. It is still an exception to a rule, but one that
> can be better justified.
>
> Thanks,
> Pedro
>

I have updated both the implementation and the RFC to reflect this
exception for constructors. If no further discussion comes up, I'll open
the vote in a few days.

Regards,
Pedro


   

Thread (11 messages)

• Pedro MagalhãesFri, 22 May 2020 15:43:08 +0000
  • Marco PivettaFri, 22 May 2020 16:25:58 +0000
    • Bruce WeirdanFri, 22 May 2020 20:06:57 +0000
      • Marco PivettaFri, 22 May 2020 20:18:52 +0000
    • Pedro MagalhãesTue, 26 May 2020 14:34:01 +0000
      • Marco PivettaTue, 26 May 2020 14:46:22 +0000
        • Pedro MagalhãesTue, 26 May 2020 23:07:44 +0000
          • Alexandru PătrănescuWed, 27 May 2020 07:23:36 +0000
            • Pedro MagalhãesWed, 27 May 2020 08:40:02 +0000
          • Pedro MagalhãesMon, 08 Jun 2020 15:58:46 +0000
            • Marco PivettaMon, 08 Jun 2020 16:06:26 +0000