Re: Drop warning about non-public magic methods

From: Date: Tue, 14 Jul 2020 01:44:45 +0000
Subject: Re: Drop warning about non-public magic methods
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-110990@lists.php.net to get a copy of this message
Hi Grabriel, Hello internals, > > During the development of > https://wiki.php.net/rfc/magic-methods-signature > I > found something that I'd like to share with you, and possibly propose to > drop it: there's a warning that php-src throws when a magic method is > declared with visibility different than public: > https://3v4l.org/LKnKB. > > This warning does not make much sense as the magic method is executed > regardless of its visibility. Should it be dropped? > > - Gabriel Caruso > Besides the BC break involved is there any other constraint not to emit a full compile error given that the engine still executes the method call and the visibility, other than public, is therefore invalid code? Ty, Márcio

« previous php.internals (#110990) next »