Re: Drop warning about non-public magic methods
| From: | Nikita Popov | Date: | Tue, 14 Jul 2020 08:54:29 +0000 |
| Subject: | Re: Drop warning about non-public magic methods | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-110995@lists.php.net to get a copy of this message | ||
On Mon, Jul 13, 2020 at 9:32 PM Mark Randall <marandall@php.net> wrote:
> On 13/07/2020 19:32, Gabriel Caruso wrote:
> > This warning does not make much sense as the magic method is executed
> > regardless of its visibility. Should it be dropped?
> This seems to be the bigger issue... if something is specified as
> private, nothing outside its scope has any rights to access it, and that
> it does feels unexpected.
>
> __call should be checked for access IMHO.
>
I agree. We can drop the warning, but only if make __call() actually
respect visibility.
Nikita