Git workflow, PRs and php-cvs ML
| From: | Matteo Beccati | Date: | Wed, 16 Sep 2020 10:43:40 +0000 |
| Subject: | Git workflow, PRs and php-cvs ML | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-111870@lists.php.net to get a copy of this message | ||
Hey everybody,
I've noticed a test failing today on my CI and went through my local
php-cvs ML archive to see what could have caused it, without finding a
match. That has happened a few times already and I believe it was always
with some "Closes GH-XXX" commits.
I'm just guessing here, but maybe in those cases the git workflow from
our wiki page wasn't properly followed when merging pull requests?
https://wiki.php.net/vcs/gitworkflow
Today's example:
https://github.com/php/php-src/pull/5803
Cheers
--
Matteo Beccati
Development & Consulting - http://www.beccati.com/