Re: Git workflow, PRs and php-cvs ML
| From: | Nikita Popov | Date: | Wed, 16 Sep 2020 10:46:40 +0000 |
| Subject: | Re: Git workflow, PRs and php-cvs ML | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-111871@lists.php.net to get a copy of this message | ||
On Wed, Sep 16, 2020 at 12:44 PM Matteo Beccati <php@beccati.com> wrote:
> Hey everybody,
>
> I've noticed a test failing today on my CI and went through my local
> php-cvs ML archive to see what could have caused it, without finding a
> match. That has happened a few times already and I believe it was always
> with some "Closes GH-XXX" commits.
>
> I'm just guessing here, but maybe in those cases the git workflow from
> our wiki page wasn't properly followed when merging pull requests?
>
> https://wiki.php.net/vcs/gitworkflow
>
> Today's example:
> https://github.com/php/php-src/pull/5803
>
No, this just means that your CI is running tests that our CI doesn't. In
this case, you are probably using a different MySQL version and thus run a
different subset of tests.
Nikita