Re: [rfc:direct-execution-opcode] Whether need __FILE__ the value of the file to replace the compiled opcode file path

Hi Chopins Xiao, Some comments on https://wiki.php.net/rfc/direct-execution-opcode 1) This should be marked as "Status: Under Discussion" in the RFC document itself, not draft? 2) https://wiki.php.net/rfc/howto states: > 5. Listen to the feedback, and try to answer/resolve all questions. > **Update your RFC to document all the issues and discussions. > Cover both the positive and negative arguments.** Put the RFC URL into all your replies. The RFC guidelines mention this should document the negative arguments, e.g. as a Discussion section with quotes of the negative arguments (arguments against the RFC) and positive arguments. I'd recommend linking to the discussions on the mailing list, as there had been a lot of discussion there, e.g. as a References section at the end of the document https://externals.io/message/112482 and https://externals.io/message/111965 and https://externals.io/message/111979 ---- https://wiki.php.net/rfc/direct-execution-opcode#backward_incompatible_changes was also unclear to me > Magic constant __FILE__ is the absolute path to the compiled > source file, not the path to the opcode file that is currently executing "to the compiled source file" should be clarified to say something like "to the compiled source file for the packager (not the end user)" (e.g. require_once __DIR__ . '/other.php' would get converted to the opcode INCLUDE_OR_EVAL (require_once) string("/home/packagerusername/other.php") even with optimizations disabled, which would be unexpected for the packager and the end user) I don't think there are any problems with __LINE__, that's the line number within the file, and is unchanged by the path to the file. Regards, - Tyson