Re: Info needed
| From: | Derick Rethans | Date: | Thu, 15 Jul 2004 10:00:11 +0000 |
| Subject: | Re: Info needed | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-11250@lists.php.net to get a copy of this message | ||
On Wed, 14 Jul 2004, Kamesh Jayachandran wrote:
> Hi Derick,
> Thanks for responding.
> I am posting my patches module by module.
> For zend you can find the patches at the following locations.
> http://puggy.symonds.net/~kameshj/zendnetwarepatches.tar.gz
1. This patch is the wrong way around (you swapped old and new in the
diff command).
2. Tons of whitespace is introduced (bad idea to mix with code changes)
3. I think you screwed up line ending problems, all our code has Unix
style line endinds.
other than that it looks okay, though I'm not sure if we need too those
really long comments in the code.
regards,
Derick