Re: Info needed
| From: | Kamesh Jayachandran | Date: | Thu, 15 Jul 2004 10:08:38 +0000 |
| Subject: | Re: Info needed | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-11252@lists.php.net to get a copy of this message | ||
Hi Derick,
Can you guide me how to produce the patch?
I thought
'diff -u newsource oldsource '
will give the patch.
Is it other way round?
I will lokk into white space issue.
With regards
Kamesh Jayachandran
On Thu, 15 Jul 2004 12:00:11 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:
> On Wed, 14 Jul 2004, Kamesh Jayachandran wrote:
>
> > Hi Derick,
> > Thanks for responding.
> > I am posting my patches module by module.
> > For zend you can find the patches at the following locations.
> >
> > http://puggy.symonds.net/~kameshj/zendnetwarepatches.tar.gz
>
> 1. This patch is the wrong way around (you swapped old and new in the
> diff command).
>
> 2. Tons of whitespace is introduced (bad idea to mix with code changes)
>
> 3. I think you screwed up line ending problems, all our code has Unix
> style line endinds.
>
> other than that it looks okay, though I'm not sure if we need too those
> really long comments in the code.
>
> regards,
> Derick