PR for minor bugfix in compact()
| From: | David Gebler | Date: | Wed, 28 Apr 2021 11:12:37 +0000 |
| Subject: | PR for minor bugfix in compact() | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-114229@lists.php.net to get a copy of this message | ||
Hi internals,
I've opened a PR to cause compact() to throw a TypeError if its parameters
are not valid, which I consider to be a fix for what is effectively a bug
whereby logical errors in user code can be silently swallowed.
GPB has done an initial review and left a comment
https://github.com/php/php-src/pull/6921#pullrequestreview-646848902
in
which he suggests I open this up to the floor, so here it is, seeking
your feedback kindly. Also if anyone can clarify what is meant by a warning
"will be promoted in PHP 9", I am not familiar with what changes are
planned for the next major version?
Regards
David