Re: PR for minor bugfix in compact()
| From: | Ben Ramsey | Date: | Fri, 07 May 2021 23:13:36 +0000 |
| Subject: | Re: PR for minor bugfix in compact() | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-114296@lists.php.net to get a copy of this message | ||
Christian Schneider wrote on 5/7/21 02:06:
> I agree with George that it should be an E_WARNING first and then changed to a TypeError in PHP
> 9.
> This should be the default process for reasons given in many other threads about tightening
> type rules IMHO.
>
> So no, I'd prefer if this PR to be changed to E_WARNING before merging it.
>
> - Chris
>
Not a lot of chatter about this on the list, but I also agree that this
should be an E_WARNING in 8.1 and promoted to a TypeError in PHP 9. This
is our standard process.
David, please update the PR, and we'll get it merged.
Cheers,
Ben
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc