Re: timelib performance fix

Hi Dmitry, On Mon, Aug 30, 2021 at 8:54 PM Dmitry Stogov <dmitrystogov@gmail.com> wrote: > Please, let me know you decision according > https://github.com/derickr/timelib/pull/99 > > This workaround fix makes ~170 times improvement on "new DateTimeZone()" > and as result visible improvement on some real-life apps (e.g Symfony demo > gets ~7% according to callgrind). > This is a huge difference. > > The fix was proposed more than a half year ago... > It would be great to include it into PHP-8.1 release. Such improvements are more than welcome, especially for such obvious patch. One could argue that the length of the data may change in the future but it can be increase then, or a macro can define it easily. It is late in the run to include it, but if RMs are OK, I would be all for applying it. The lib is bundled and whether the external repository applies it should not be relevant at this point (also no activity in 2 years there), or? Cheers, -- Pierre @pierrejoye | http://www.libgd.org