Re: timelib performance fix
| From: | Kalle Sommer Nielsen | Date: | Tue, 31 Aug 2021 21:18:27 +0000 |
| Subject: | Re: timelib performance fix | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-115908@lists.php.net to get a copy of this message | ||
Den tir. 31. aug. 2021 kl. 09.10 skrev Pierre Joye <pierre.php@gmail.com>:
> It is late in the run to include it, but if RMs are OK, I would be all
> for applying it. The lib is bundled and whether the external
> repository applies it should not be relevant at this point (also no
> activity in 2 years there), or?
The external library is important because you can update the pecl
release of that in the middle of a PHP release if an update comes out,
which is good if you are locked to a specific version of PHP. Loading
in the pecl/timelib extension will override the internal version,
however if this fix is only applied to the bundled library, but not
synced upstream, then it breaks this philosophy.
--
regards,
Kalle Sommer Nielsen
kalle@php.net