Re: [RFC][Vote] Auto-capture closures
| From: | Marco Pivetta | Date: | Tue, 05 Jul 2022 07:27:34 +0000 |
| Subject: | Re: [RFC][Vote] Auto-capture closures | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118192@lists.php.net to get a copy of this message | ||
On Mon, 4 Jul 2022, 19:15 Arnaud Le Blanc, <arnaud.lb@gmail.com> wrote:
> > Important to note how
Zend/zend_compile.c now depends on
> > Optimizer/,
> > which is a potential design issue.
>
> The Optimizer was moved to Zend/Optimizer earlier so that in
> the long
> term
> it could be used by the compiler pipeline directly (rather than as part of
> caching).
>
Thanks for clarifying!
>
> There are clear benefits in reusing the Optimizer here. Duplicating or
> reimplementing live variable analysis would increase maintenance cost,
> whereas
> by reusing the Optimizer's implementation we take profit of a fast and
> well
> tested implementation.
>
> Greets,
>
This is fine, but it creates a bidirectional dependency between components
where the dependency graph was previously (in theory) acyclic.
This will become "someone else's problem" 😬