Re: [RFC][Vote] Auto-capture closures
| From: | Arnaud Le Blanc | Date: | Tue, 05 Jul 2022 16:33:12 +0000 |
| Subject: | Re: [RFC][Vote] Auto-capture closures | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118200@lists.php.net to get a copy of this message | ||
On mardi 5 juillet 2022 09:27:34 CEST Marco Pivetta wrote:
> This is fine, but it creates a bidirectional dependency between components
> where the dependency graph was previously (in theory) acyclic.
>
> This will become "someone else's problem" 😬
I don't think that the Optimizer conceptually depends on the Compiler
currently. It does include
Zend/zend_compile.h, but that's only for the
types defined in this header. It needs these types because its responsibility
is to transform data structures produced by the compiler (op_arrays), or in
this case, to produce meta data about these structures. These types can be
trivially moved to an other header. It doesn't call any compiler code. Also,
this doesn't introduces circular includes involving Zend/zend_compile.h. Does
it seems ok to you ?