Re: ksort breaking change

From: Date: Fri, 26 Aug 2022 12:19:40 +0000
Subject: Re: ksort breaking change
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-118507@lists.php.net to get a copy of this message
On 26.08.2022 at 05:15, Go Kudo wrote: > In the actively supported version of PHP, ksort() has been > modified to > include BC Break. > > https://github.com/php/php-src/issues/9296 > > This may seem like an appropriate bug fix, but it is a clear BC Break. I > think this change should only be introduced in PHP 8.2 and later. In this case, the functions didn't behave as documented, namely to conform to the general conversion rules, which had a relevant change in PHP 8.0. Apparently, this case has been overlooked when the change had been implemented, and only been noticed recently (what still surprises me). Anyway, fixing the issue now is not really introducing a BC break, since code relying on the previous behavior did not conform to the documentation. > Fortunately, there is not yet a release in each version that incorporates > this change. I think it is possible to revert now. Well, the fix is part of the currents RCs; that doesn't make it impossible to revert, but RMs should have a say in that. Thus I'm adding Sara and Gabriel as recepients. -- Christoph M. Becker

« previous php.internals (#118507) next »