Re: ksort breaking change
| From: | juan carlos morales | Date: | Fri, 26 Aug 2022 14:59:20 +0000 |
| Subject: | Re: ksort breaking change | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118513@lists.php.net to get a copy of this message | ||
Oh! My bad. Nice work! Cheers
El vie., 26 de agosto de 2022 16:51, Tim Düsterhus <tim@bastelstu.be>
escribió:
> Hi
>
> On 8/26/22 16:15, juan carlos morales wrote:
> > Seems like we Don't Have tests for the function or we should enhance the
> > existing ones. If We would Have proper tests the FIX would break it (as I
> > Don't see tests in the fix itself).....That is why I say so.
> >
>
> Various tests were adjusted in:
> https://github.com/php/php-src/pull/9293/files
>
> Best regards
> Tim Düsterhus
>