Re: RFC [Discussion]: Improve unserialize() error handling
| From: | Tim Düsterhus | Date: | Wed, 07 Sep 2022 15:37:07 +0000 |
| Subject: | Re: RFC [Discussion]: Improve unserialize() error handling | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118574@lists.php.net to get a copy of this message | ||
Hi
On 9/5/22 23:12, Larry Garfield wrote:
Can you please clarify whether you mean: 1. Change the existing E_WARNING option to "E_WARNING+Exception in 9.0". 2. Add a new "E_WARNING+Exception in 9.0" option the vote, such that the vote will be "E_WARNING" vs "E_WARNING+Exception in 9.0" vs "Exception" Best regards Tim DüsterhusRFC: Improve unserialize() error handling https://wiki.php.net/rfc/improve_unserialize_error_handlingWell-explained and well-argued. The only thing I'd add is that we should consider bumping the E_NOTICE to an E_WARNING, *and* slating it to increase to an exception in 9.0. This feels like a smaller BC concern than most, but people are extra sensitive these days about those edge cases so it's probably good to be cautious.