Re: RFC [Discussion]: Improve unserialize() error handling
| From: | Tim Düsterhus | Date: | Tue, 27 Sep 2022 20:01:35 +0000 |
| Subject: | Re: RFC [Discussion]: Improve unserialize() error handling | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118694@lists.php.net to get a copy of this message | ||
Hi
On 9/8/22 18:36, Larry Garfield wrote:
Thank you, I thought about what to do here and I've adjusted the options in the "increase to what" vote to make this a 3-way vote: https://wiki.php.net/rfc/improve_unserialize_error_handling#increasing_the_severity_of_existing_warningsnotices Do you believe that my reasoning with regard to the interpretation of the vote's results is sound? A ranked choice vote should not necessary here, because the three options follow a natural order with regard to severity/possible breakage. Best regards Tim DüsterhusWe've done this kind of two-step thing before; a lot of PHP 8 changes were voted on well in advance of 8.0's release. A "Warning now, Exception in 9" vote would not be unprecedented.Either I guess? Honestly we should decide that in advance on the list. :-) E_WARNING+Exception in 9 is what I'd probably favor, with "Exception now" as a second choice.