Re: [PATCH] Passthrough MD5/SHA1 calculation of uploaded files
| From: | Derick Rethans | Date: | Wed, 04 Aug 2004 15:06:45 +0000 |
| Subject: | Re: [PATCH] Passthrough MD5/SHA1 calculation of uploaded files | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-11911@lists.php.net to get a copy of this message | ||
On Wed, 4 Aug 2004, David Santinoli wrote:
> I'm submitting a patch to perform "on the fly" MD5/SHA1 digest
> calculation of a file uploaded via the HTTP POST method. Being
> not uncommon for applications to require some digest of a freshly
> uploaded file, doing the math directly in the buffer where the file is
> being read can save some time.
I like this idea, and the patch looks (from a glance OK). Without
applying it I have a question though:
Does it handle cleaning up the digest structures correctly if the
fileupload is aborted in some way?
regards,
Derick