Re: [PATCH] Passthrough MD5/SHA1 calculation of uploaded files

On Wed, Aug 04, 2004 at 05:06:45PM +0200, Derick Rethans wrote: > > I like this idea, and the patch looks (from a glance OK). Without > applying it I have a question though: > > Does it handle cleaning up the digest structures correctly if the > fileupload is aborted in some way? Do you refer to the PHP_MD5_CTX and PHP_SHA1_CTX contexts? AFAIK, given they're automatic variables with no malloc()ed buffers inside them, it doesn't look like an explicit cleanup is needed. Cheers, David PS I'm on the list! CC:ing to my private address is unnecessary. -- David Santinoli, Milano + <david@santinoli.com> Independent Linux/Unix consultant + http://www.santinoli.com