Re: [RFC] Unicode Text Processing

Hi On 12/15/22 16:34, Derick Rethans wrote:

You can find it at: https://wiki.php.net/rfc/unicode_text_processing I'm looking forwards to hearing your opinions, additions, and suggestions — the RFC specifically asks for these in places.

Some first remarks: ---------- replaceText(): In the replaceText() section the description refers to a non-existent parameters '$maxReplacements' and '$collator'. Also the second paragraph in that section looks like a word is missing there. ---------- getPositionOfFirstOccurrence(): I agree this is too long. How about: - findOffset() - findOffsetLast() And for returnFromFirstOccurence(): - startingWith() - startingWithLast() ---------- firstToTitle(): I don't see how this differs from toTitle() and/or firstToUpper(). An example would likely be helpful. ---------- wordsToTitle(): Likewise. ---------- The return of many methods is not explicitly listed. I'd put it everywhere to make it 100% clear that all those functions return 'Text'. Best regards Tim Düsterhus