Re: LDFLAGS broken?
| From: | Max Kellermann | Date: | Wed, 22 Feb 2023 13:14:08 +0000 |
| Subject: | Re: LDFLAGS broken? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-119594@lists.php.net to get a copy of this message | ||
On 2023/02/22 13:45, Max Kellermann <max+php@blarg.de> wrote:
> 13 years ago, there was commit
> https://github.com/php/php-src/commit/477649cd3f09 which
> attempted to
> fix this, but was reverted on the same day by commit
> https://github.com/php/php-src/commit/16450418b188 with just
> commit
> message "Revert bad patch" but nothing else, no explanation what was
> bad about the patch.
Oh look, there was an "edit war" with a bunch of commits repeatedly
adding and commenting this "unset LDFLAGS" line:
https://github.com/php/php-src/commit/c4d84aa33390
https://github.com/php/php-src/commit/21a6e1f96229
https://github.com/php/php-src/commit/937358ebc7a6
https://github.com/php/php-src/commit/477649cd3f09
https://github.com/php/php-src/commit/16450418b188