Re: LDFLAGS broken?
| From: | Max Kellermann | Date: | Thu, 23 Feb 2023 04:46:00 +0000 |
| Subject: | Re: LDFLAGS broken? | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-119596@lists.php.net to get a copy of this message | ||
On 2023/02/22 22:09, Peter Kokot <petk@php.net> wrote:
> >From my quick check, the unset is initially done to move the currently
> set flags to extra flags variable and clean the variable for further
> additions so there are no duplicate ones or something like that.
>
> https://github.com/php/php-src/commit/9417570dc1f31a0e3ddb9f6736a547c87ce7cfba
>
> There seems to be another unset done to this change here:
>
> https://github.com/php/php-src/commit/c4d84aa33390045cd4ff542719a0f79cff52fb7c
> which fixed some bugs related to linker errors and duplicate symbols.
Smells like people doing random things until some bug disappears...
and no commit messages here either, no explanation for the change.
> Most likely, some of those three unset lines could be removed today,
> yes, but I can't be sure. If removal would fix some bug, then probably
> it is time to remove them and see where things break afterwards.
Yes, it fixes bugs. Once my other build system improvement PRs are
merged (the CFLAGS mess), I'll submit a patch to fix the LDFLAGS mess.
Max