Re: PHP code refactoring (was: include cleanup)

Am 28.02.2023 um 22:04 schrieb Max Kellermann <max+php@blarg.de>: > On 2023/02/28 21:16, Dmitry Stogov <dmitrystogov@gmail.com> wrote: >> Recently we voted for inluce cleanup RFC >> https://wiki.php.net/rfc/include_cleanup and it was >> declined. > > Which specific commits do you wish to revert? Is this about include > cleanups (none of which were merged) or about header splitting (which > a supermajority voted for) or about other kinds of code refactoring > (which was not voted on)? You keep saying that people voted yes on the secondary vote (clarifications on how to clean up). Just to clarify: This is irrelevant as the primary vote was declined. > My opinion is: if a patch improves a piece of code, it should be > merged. Of course, whether something is an improvement is debatable; > but postponing that decision is pointless and harmful. As far as I can see there seems to be a disagreement whether it is an improvement, which to me sounds like there must be more discussion. Which means the decision has to be postponed, no? I second Dmitry's request to do things in a managed way. What exactly caused the disruption I'm not sure and it is not about blaming someone but finding a workable solution. Regards, - Chris