Re: PHP code refactoring (was: include cleanup)

On Tue, Feb 28, 2023 at 11:59 PM Dan Liebner <dliebner@gmail.com> wrote: > Which commit? > just some of them: https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382bf1e0 https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea4920b1c7 https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595e5f60 Thanks. Dmitry. > > On Tue, Feb 28, 2023, 3:17 PM Dmitry Stogov <dmitrystogov@gmail.com> > wrote: > >> Hi @internals, >> >> I have to say that we came to a serious conflict. >> >> Recently we voted for inluce cleanup RFC >> https://wiki.php.net/rfc/include_cleanup and it was >> declined. >> Despite that a series of code refactoring commits from Max were silently >> merged into the master. >> As this is a violation of the community rules and we should do something.. >> In my opinion, this should be reverted (I would even think about rebasing >> to not pollute the git history). >> >> Personally, I don't like this refactoring, because it is mainly about >> coding preferences and habits. >> Anyway, I see that some people like this. Maybe this may attract new >> developers. >> >> OK. Let's do this, but do this in a managed way. The massive uncontrolled >> changes is the main problem in the current situation. >> Let's define the goal(s), rules, make a plan, summarize this in a new RFC, >> accept it. >> Then most of the work should be done in a separate branch and merged into >> the master all together after a final review. >> I (and other authority contributors) wouldn't be able to object against >> the >> terms accepted in RFC. >> So a good RFC should be a half of success... >> It would be great if PHP Foundation could assign some experienced >> developer(s) to be part of this work. >> >> Thanks. Dmitry. >> >