Re: [RFC] [Vote] Deprecate functions with overloaded signatures

> On Jun 26, 2023, at 08:36, Máté Kocsis <kocsismate90@gmail.com> wrote: > > Hi Everyone, > > As previously announced on the list, I have just started the vote about the > "Deprecate functions with overloaded signatures". > > Link to the RFC: > > https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures > Link to the discussion thread: > https://externals.io/message/120146 > > The vote is open until 2023-07-10 16:00:00 UTC. > > Regard, > Máté Clarifying my “no” votes… I voted “no” on array_keys() because I do not see these as two different function signatures. To me, the single signature should look like this: function array_keys(array $array, ?mixed $filter_value = null, bool $strict = false): array {} I voted “no” on IntlCalendar::set() because it seems to me that setDate() and setDateTime() could share the same signature if $hour, $minute, and $second all default to zero, like this: public function setDate(int $year, int $month, int $dayOfMonth, int $hour = 0, int $minute = 0, int $second = 0): void {} In the same way, with IntlGregorianCalendar::__construct(), createFromDate() and createFromDateTime() could be combined as: public static function createFromDate(int $year, int $month, int $dayOfMonth, int $hour = 0, int $minute = 0, int $second = 0): void {} Cheers, Ben

Attachment: [application/pgp-signature] Message signed with OpenPGP signature.asc