Re: Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

Hi Niels, On 29.09.23 09:07, Niels Dossche wrote:

Hi internals Discussion seems to have died down. Today, it's been 14 days since the last major change was done to the RFC (i.e. the class hierarchy update). And it's also been close to 4 weeks since I first announced the RFC it on the mailing list. I'd like to start the vote on Monday (20:00 PM GMT+2) and I intend to let it run for 2 weeks. Any final complaints should be raised now.

Not much to complain but a question - not sure if it was discussed before. Naming: XMLDocument::fromEmpty vs. HTMLDocument::createEmpty in the PHP code section. For both, XMLDocument::fromEmpty and HTMLDocument::createEmpty there is an argument available to define the encoding but none of the other createFrom* methods have this argument. As far as I understand, in the these other cases the encoding gets detected from the content of the passed source but what happens is the source does not contain any information about the encoding?. E.g. you load an XML/HTML document over HTTP, the encoding is defined via HTTP header but the content itself doesn't contain it.

Kind regards Niels Best,

Marc

Attachment: [application/pgp-keys] OpenPGP public key OpenPGP_0x3936ABF753BC88CE.asc
Attachment: [application/pgp-signature] OpenPGP digital signature OpenPGP_signature.asc