Re: Re: cvs: php-src /ext/imap php_imap.c

Quit complaining and fix the patch properly then. --Wez. On Thu, 12 Aug 2004 17:55:33 +0200, Jan Schneider <jan@horde.org> wrote: > Zitat von Jan Schneider <jan@horde.org>: > > > Ilia Alshanetsky wrote: > >> iliaa Wed Jul 21 17:57:03 2004 EDT > >> > >> Modified files: /php-src/ext/imap php_imap.c Log: > >> Fixed bug #29209 (imap_fetchbody() doesn't check message index). > >> # Initial Patch by tony2001 at phpclub dot net > >> > >> > >> http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.185&ty=u > > > > This "fix" breaks retrieving message bodies if not using the sequence > > number in imap_fetchbody() but the UID instead. > > > > imap_fetchbody($stream, 1, 1, FT_UID) > > doesn't work anymore, while > > imap_fetchbody($stream, imap_msgno($stream, 1), 1) > > works. > > > > Jan. > > > > P.S.: this patch has been committed to all branches. > > Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as it > breaks every second application using the imap extension to retrieve > messages, including IMP. > > Jan. > > -- > Do you need professional PHP or Horde consulting? > http://horde.org/consulting.php > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >