Re: Re: cvs: php-src /ext/imap php_imap.c

OK guys. I'd like to roll so please check this problem and give me an ack if it's OK. At 02:38 PM 8/12/2004 -0400, Ilia Alshanetsky wrote:

Chuck already applied a patch that should resolve the problem that Jan had reported. Ilia On August 12, 2004 02:21 pm, Andi Gutmans wrote: At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote:

Zitat von Jan Schneider <jan@horde.org>:

Ilia Alshanetsky wrote:

iliaa           Wed Jul 21 17:57:03 2004 EDT

  Modified files:                  /php-src/ext/imap    php_imap.c

Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # Initial Patch by tony2001 at phpclub dot net http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.18 5&ty=u

This "fix" breaks retrieving message bodies if not using the sequence number in imap_fetchbody() but the UID instead. imap_fetchbody($stream, 1, 1, FT_UID) doesn't work anymore, while imap_fetchbody($stream, imap_msgno($stream, 1), 1) works. Jan. P.S.: this patch has been committed to all branches.

Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as it breaks every second application using the imap extension to retrieve messages, including IMP.

Ilia, Tony, Any idea? We should probably revert this patch and make imap behave in the previous manner until a real fix is found. Andi