Re: Re: [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

On 10/05/2024 16:31, Larry Garfield wrote: > On Fri, May 10, 2024, at 2:03 PM, Niels Dossche wrote: >> On 22/04/2024 20:41, Niels Dossche wrote: >>> Hi internals >>> >>> I'm opening the discussion for my RFC "Add openStream() to >>> XML{Reader,Writer}". >>> RFC link: >>> https://wiki.php.net/rfc/xmlreader_writer_streams >>> >>> Kind regards >>> Niels >> >> Hi internals >> >> It's been over two weeks since I opened the discussion. >> Please raise any last concerns now. >> I'd like to start voting next week Monday. >> >> Kind regards >> Niels > > Please include some examples of what a full usage would look like with the new additions. > I'm not super experienced with those libraries right now, but the "create the object, THEN > populate it with its data source" pattern feels very weird to me. (Though at least it's > consistent now rather than as it was before, thanks.) > > --Larry Garfield Hi Larry I added minimal examples for both. The streams I used are just the memory and output streams for simplicity so that it can be tested on its own. Kind regards Niels