Re: [RFC] Asymmetric Visibility, v2
| From: | Rob Landers | Date: | Fri, 26 Jul 2024 15:35:07 +0000 |
| Subject: | Re: [RFC] Asymmetric Visibility, v2 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-124620@lists.php.net to get a copy of this message | ||
On Fri, Jul 26, 2024, at 16:27, Larry Garfield wrote:
> On Fri, Jul 26, 2024, at 12:58 PM, Rob Landers wrote:
>
> >> And now that I see it spelled out more, I do agree that while it appears a bit more
> >> verbose, and this "(set)" looks odd at first, having all the visibility upfront is a lot
> >> clearer than having to read through the hooks to see what visibility applies.
> >
> > On a large property hook that potentially span hundreds of lines, I'd
> > rather only need to scroll up to the "set =>" to see how it is set vs.
> > going all the way back up to the property itself.
>
> If someone has a property hook that is hundreds of lines long, their code is already crap and
> there's no hope for them.
>
> --Larry Garfield
>
True, but we don't always get to choose what code we work on.
— Rob