Re: [Concept] Flip relative function lookup order (global, then local)

On Mon, Aug 5, 2024 at 1:23 PM Derick Rethans <derick@php.net> wrote: > > On Fri, 2 Aug 2024, Ilija Tovilo wrote: > > > As for providing a migration path: One approach might be to introduce > > an INI setting that performs the function lookup in both local and > > global scope at run-time, and informs the user about the behavioral > > change in the future. > > That INI setting would control the *warning*, and not the > *functionlity*, right? Yes, that was my suggestion. First, in a future minor version, an INI option could be added that would warn when finding both a local and global function when performing an unqualified function call. The only reason to hide this behind a setting is to avoid the cost of a double lookup in production code when one isn't necessary, i.e. when calling local functions in some namespace. > I am surprised that it is that much of a performance benefit as well, > but I am also concerned about the BC impact. But if that isn't too much, > then I guess we need to consider this, but only for a major version. Not > something I believe we can change in a 8.x version. Sure, waiting for 9.0 sounds reasonable if we were to choose this approach. Ilija