Re: PDO\Sqlite: Add transaction mode attribute

Hi, Is there anything I could do here to get this reviewed before the 8.5 release? As mentioned earlier the proposed implementation should not be subject to the feature freeze. <https://github.com/php/php-src/pull/19317> Thank you. Samuel On August 12, 2025, "Samuel Štancl" <samuel@archte.ch> wrote: > By enums I'm assuming you mean PHP enums. That could work and would > solve my issue of trying to represent the values of the attribute > (only thing I'm not sure about is Pdo\SqliteTransactionMode being > directly in the Pdo namespace). I've included a sample implementation > in this comment <https://github.com/php/php- > src/pull/19317#issuecomment-3177353751> > > On August 12, 2025, Morgan <weedpacket@varteg.nz> wrote: > > On 2025-08-12 07:35, Samuel Štancl wrote: > > > > > > Hi, I've opened a PR adding a new attribute to PDO\Sqlite: > > https:// > > > github.com/php/php-src/pull/19317 > > > <<https://github.com/php/php- > > src/>  > > > pull/19317?  > > > > > notification_referrer_id=NT_kwDOAfgLhrQxNzkxMjcwMjYzOTozMzAzMzA5NA#issuecomment- > > 3176177745> > > >  > > As far as the form the attribute takes goes, an Enum with the > > values  > > DEFERRED/IMMEDIATE/EXCLUSIVE would do the job. > > > > (As for calling it an attribute, I thought at first that what was > > being  > > suggested was an Attribute, rather than a connection option.) >