Re: PDO\Sqlite: Add transaction mode attribute
| From: | Samuel Štancl | Date: | Thu, 04 Sep 2025 08:40:46 +0000 |
| Subject: | Re: PDO\Sqlite: Add transaction mode attribute | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-128630@lists.php.net to get a copy of this message | ||
Hi Matteo,
From reading earlier discussions my understanding is the feature freeze
only applies to things that need RFCs. With PRs that add simple
constants not necessarily needing an RFC.
Personally I think the diff in the linked PR itself matches that
description well, while the alternative implementation in the comment
seems more likely to need an RFC.
If I need RM approval how would I go about that. Email one of the RMs
individually?
Thank you.
Samuel Štancl
On September 4, 2025, Matteo Beccati <php@beccati.com> wrote:
> Hi Samuel,
>
> Il 04/09/2025 00:38, Samuel Štancl ha scritto:
> > Hi,
> >
> > Is there anything I could do here to get this reviewed before the
> 8.5
> > release? As mentioned earlier the proposed implementation should not
> be
> > subject to the feature freeze.
> >
> > https://github.com/php/php-src/pull/19317
> <https://github.com/php/php-
> > src/pull/19317>
>
> I think the 8.5 ship has sailed. Why should it not be subject to
> feature
> freeze? It surely is, unless the RMs approve it.
>
>
> Cheers
> --
> Matteo Beccati