Re: Update on the lexer-no-stdio patch
| From: | Wez Furlong | Date: | Tue, 06 May 2003 10:53:27 +0000 |
| Subject: | Re: Update on the lexer-no-stdio patch | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-1294@lists.php.net to get a copy of this message | ||
beware of the streams own buffer filling code here though.
(Hmm, I've a feeling we've been here before).
--Wez.
On Tue, 6 May 2003, Sascha Schumann wrote:
> On Tue, 6 May 2003, Wez Furlong wrote:
>
> > It is set to 1 so that we dont miss the end of the headers when reading
> > the response. (this is a legacy of pre-streams code).
>
> read(fd, buf, 8192) will return once a single packet arrives;
> it won't wait until the connection dies or the buffer is
> full.
>
> As such, the chunk size 1 code can be savely deleted.
>
> > I am concerned about the presence of spaces in your strace; it could
> > indicate a problem in the chunking code in the _php_stream_write
> > function.
>
> That was on Solaris/x86, I don't see it right now on Linux.
>
> - Sascha
>
>
>