Re: [PATCH] tests/classes/factory_and_singleton_009.phpt
| From: | Marcus Boerger | Date: | Thu, 23 Sep 2004 19:07:01 +0000 |
| Subject: | Re: [PATCH] tests/classes/factory_and_singleton_009.phpt | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-12951@lists.php.net to get a copy of this message | ||
Hello Kamesh,
doesn't work for me. And if you were right we would see those tests FAILing
in all php 5 test reports. There must be another problem.
regards
marcus
Thursday, September 23, 2004, 1:15:30 PM, you wrote:
> Hi Helly,
> I had the tests/classes/factory_and_singleton_009.phpt testcase failing
> in Linux, NetWare, Windows ports of PHP.
> And found that this failure is due to one extra line.
> Attached the patch.
> Similar issue exists in tests/classes/factory_and_singleton_010.phpt
> Actually after ===DONE=== newline preceded in warning message brings the
> cursor to next immedeate line with a warning message. So expecting one
> more new line between ===DONE=== and warning message is incorrect.
> Correct me if I am wrong.
> If I am correct can I go ahead and commit it.
> With regards
> Kamesh Jayachandran
--
Best regards,
Marcus mailto:helly@php.net