Re: [PATCH] tests/classes/factory_and_singleton_009.phpt
| From: | Kamesh Jayachandran | Date: | Fri, 24 Sep 2004 07:20:15 +0000 |
| Subject: | Re: [PATCH] tests/classes/factory_and_singleton_009.phpt | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-12960@lists.php.net to get a copy of this message | ||
Hi Marcus,
For me also this test is going through if I run the test using
run-tests.php.
But it fails with run-tests2.php
With run-tests2.php
I could see the output from the execute function itself was lacking that
one new line character that exists between
===DONE=== and the actual waring line.
The only difference I could see is the way the php
factory_and_singleton_009.php
In run-tests.php
All the -d option value pairs are enclosed by double quote
has extra options -d "xdebug.default_enable=0" -d "session.auto_start=0"
runs the script with -f option.
With regards
Kamesh Jayachandran
On Thu, 23 Sep 2004 21:07:01 +0200, "Marcus Boerger" <helly@php.net>
said:
> Hello Kamesh,
>
> doesn't work for me. And if you were right we would see those tests
> FAILing
> in all php 5 test reports. There must be another problem.
>
> regards
> marcus
>
> Thursday, September 23, 2004, 1:15:30 PM, you wrote:
>
> > Hi Helly,
> > I had the tests/classes/factory_and_singleton_009.phpt testcase failing
> > in Linux, NetWare, Windows ports of PHP.
> > And found that this failure is due to one extra line.
>
> > Attached the patch.
>
> > Similar issue exists in tests/classes/factory_and_singleton_010.phpt
>
> > Actually after ===DONE=== newline preceded in warning message brings the
> > cursor to next immedeate line with a warning message. So expecting one
> > more new line between ===DONE=== and warning message is incorrect.
>
> > Correct me if I am wrong.
>
> > If I am correct can I go ahead and commit it.
>
> > With regards
> > Kamesh Jayachandran
>
>
>
> --
> Best regards,
> Marcus mailto:helly@php.net
>