Re: [PATCH] Resubmitted for review
| From: | Andi Gutmans | Date: | Tue, 12 Oct 2004 22:37:36 +0000 |
| Subject: | Re: [PATCH] Resubmitted for review | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13296@lists.php.net to get a copy of this message | ||
At 12:34 AM 10/13/2004 +0200, Marcus Boerger wrote:
Hello Andi, Tuesday, October 12, 2004, 11:43:11 PM, you wrote: We were discussing adding a per class (zend_class_entry *) callback for constants. It might make sense to allow that and if the callback is NULL then try the constant's hash in zend_class_entry. That should solve all cases, right? Andi still the patch is a good extension to the engine API and i think we should add it. Why should every programmer that wants constants add constant handlers just to add some basic constants? I see the handlers only to allow soem special cases, maybe to have array consts or whatever.That's exactly what I said in my email. Allow to levels. The callback level and the hash level which Robert implemented. Re-read what I wrote :) Andi