Re: [PATCH] Resubmitted for review

Hello Andi, Wednesday, October 13, 2004, 12:37:36 AM, you wrote: > At 12:34 AM 10/13/2004 +0200, Marcus Boerger wrote: >>Hello Andi, >> >>Tuesday, October 12, 2004, 11:43:11 PM, you wrote: >> >> > We were discussing adding a per class (zend_class_entry *) callback for >> > constants. It might make sense to allow that and if the callback is NULL >> > then try the constant's hash in zend_class_entry. >> > That should solve all cases, right? >> >>Andi still the patch is a good extension to the engine API and i think >>we should add it. Why should every programmer that wants constants add >>constant handlers just to add some basic constants? I see the handlers >>only to allow soem special cases, maybe to have array consts or whatever. > That's exactly what I said in my email. Allow to levels. The callback level > and the hash level which Robert implemented. > Re-read what I wrote :) Ah! Sorry i got you wrong in that i thought you wanted the hash thingy only for user declared consts. narcus