Re: [RFC][Discussion] Add PASSWORD_BCRYPT_WRAP
| From: | Tim Düsterhus | Date: | Fri, 30 Oct 2026 08:36:23 +0000 |
| Subject: | Re: [RFC][Discussion] Add PASSWORD_BCRYPT_WRAP | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-132971@lists.php.net to get a copy of this message | ||
Hi
On 2026-10-29 21:06, Andrey Andreev wrote:
I'd like to open the discussion on a new password hashing algorithm that I've been working on, named bcrypt-wrap. RFC link: https://wiki.php.net/rfc/password_bcrypt_wrap Pull request: https://github.com/php/php-src/pull/25040 (just pushed it, CI still running)Thank you for the RFC and entertaining my questions in Discord. As promised, I want to put the points onto the list for public record: - Can you please add a (pseudo) code description of your construction to the RFC? Prose is needlessly ambiguous as also evidenced by Kamil’s misunderstanding. - The section on “bcrypt-sha256” is very vague in how your construction is better. Given that both bcrypt-sha256 and your bcrypt-wrap (with SHA-512) use a HMAC construction using the (BCrypt) salt as a key as the pre-hash, folks will rightfully wonder how the bcrypt-wrap construction is better than that of bcrypt-sha256 (other than using a different hash function) and should not be required to “reverse engineer” the differences. Best regards Tim Düsterhus