Re: [PATCH] new function stream_socket_create_pair
| From: | Vincent NEGRIER | Date: | Wed, 13 Oct 2004 09:52:42 +0000 |
| Subject: | Re: [PATCH] new function stream_socket_create_pair | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13318@lists.php.net to get a copy of this message | ||
> > the patch is here :
http://si.kz/~six/stream_socket_create_pair_patch.tgz
> >
> To add to Wez's comments, I'd rather see it return an array of socket
> streams (or FALSE on failure), rather than return true and tuck the
streams
> into a by-ref parameter.
It would look simpler, but on the other hand it would break consistency with
the behavior of socket_create_pair() and the sockpair() syscall ...
If the above is not a problem for anyone i can rewrite it to return a
streams array (or FALSE), without the byref param.
regards,
Vincent