Re: [PATCH] new function stream_socket_create_pair
| From: | six | Date: | Wed, 13 Oct 2004 18:28:45 +0000 |
| Subject: | Re: [PATCH] new function stream_socket_create_pair | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13329@lists.php.net to get a copy of this message | ||
hi,
socket type checking removed : http://si.kz/~six/stream_socket_pair.notypecheck.diff
Vincent
Wez Furlong wrote:
I wouldn't bother checking against known types; let sockpair() handle that. It is possible that someone might want/need to use some other value which we haven't thought of, or are even aware of. --Wez. On Wed, 13 Oct 2004 15:58:46 +0200, Vincent NEGRIER <six@t0x.net> wrote:Here is an updated version of the patch : http://si.kz/~six/stream_socket_pair.diff It now registers STREAM_AF_* and STREAM_SOCK_* long constants, checks the domain and type against known types and passes the array of created streams as return value instead of a byref param... and the diff is against today's CVS this time :)